Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing validation error on invalid URIs #1705

Merged
merged 2 commits into from
May 25, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented May 25, 2023

The recent update of jsonschema inadvertently caused extra validation of uri-reference formatted properties. This change ensures that these errors are converted to warnings.

Note that we cannot revert the change to jsonschema since the old version does not handle uniqueItems correctly.

Fix for #1703.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The recent update of jsonschema inadvertently caused extra validation of
`uri-reference` formatted properties. This change ensures that these
errors are converted to warnings.

Note that we cannot revert the change to jsonschema since the old
version does not handle `uniqueItems` correctly.
@aeisenberg aeisenberg requested a review from a team as a code owner May 25, 2023 17:18
@aeisenberg aeisenberg enabled auto-merge May 25, 2023 17:44
@aeisenberg aeisenberg merged commit d3314cc into main May 25, 2023
@aeisenberg aeisenberg deleted the aeisenberg/location-uri-schema-fix branch May 25, 2023 17:45
@github-actions github-actions bot mentioned this pull request May 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants